Skip to content

Conversation

@paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Oct 14, 2024

BREAKING CHANGE: Enabling CUBESQL_SQL_PUSH_DOWN is backward incompatible to many default behaviors of SQL API

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

BREAKING CHANGE: Enabling `CUBESQL_SQL_PUSH_DOWN` is backward incompatible to many default behaviors of SQL API
@paveltiunov paveltiunov requested review from a team as code owners October 14, 2024 21:43
@vercel
Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Oct 14, 2024 9:45pm
examples-react-d3 ⬜️ Ignored (Inspect) Oct 14, 2024 9:45pm
examples-react-dashboard ⬜️ Ignored (Inspect) Oct 14, 2024 9:45pm
examples-react-data-table ⬜️ Ignored (Inspect) Oct 14, 2024 9:45pm
examples-react-highcharts ⬜️ Ignored (Inspect) Oct 14, 2024 9:45pm
examples-react-material-ui ⬜️ Ignored (Inspect) Oct 14, 2024 9:45pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Oct 14, 2024 9:45pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Oct 14, 2024 9:45pm

@codecov
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.73%. Comparing base (5a4f467) to head (ac32a01).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8814   +/-   ##
=======================================
  Coverage   82.73%   82.73%           
=======================================
  Files         219      219           
  Lines       78324    78324           
=======================================
+ Hits        64804    64805    +1     
+ Misses      13520    13519    -1     
Flag Coverage Δ
cubesql 82.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit e1a8e8d into master Oct 14, 2024
77 checks passed
@paveltiunov paveltiunov deleted the default-sql-push-down branch October 14, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants